[PWGLF] Added different running mode + reworked pion selection#15432
Draft
scannito wants to merge 11 commits intoAliceO2Group:masterfrom
Draft
[PWGLF] Added different running mode + reworked pion selection#15432scannito wants to merge 11 commits intoAliceO2Group:masterfrom
scannito wants to merge 11 commits intoAliceO2Group:masterfrom
Conversation
scannito
requested review from
HorstMa,
abmodak,
alibuild,
dmallick2,
ercolessi,
fmazzasc,
gbencedi,
lhusova,
maciacco,
mpuccio,
omvazque,
prottayCMT,
romainschotter,
skundu692 and
smaff92
as code owners
Collaborator
|
Your code does not compile. How did you test it? |
Contributor
Author
|
Hi @vkucera, I tested this code locally on my macOS and it compiled just fine. So I did a bit of digging and I found out that I was actually using apple clang compiler which is outdated. I will switch to homebrew clang and test again |
Collaborator
@scannito Thanks for the details. This is worrisome. Compilation with aliBuild should work the same on your laptop as it does on the test machines. Is your local setup different from the standard one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.